Adding typehints and overloads for typing properties#125
Closed
julianstirling wants to merge 1 commit intomainfrom
Closed
Adding typehints and overloads for typing properties#125julianstirling wants to merge 1 commit intomainfrom
julianstirling wants to merge 1 commit intomainfrom
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making ThingProperty itself a generic type seems to work for getting mypy to type a property, as long as you use typing
@overloaddecorators to tell it when it is returning the descriptor rather than the value:If we go with this, we need to think about how we remove
modelso we are not double defining they type.This needs work to get MyPy passing on LabThings itself. The implementation is based off this stack exchange thread.
I minimised the number of inputs needed to
Generic. But also ruff got angry with"Descriptor"as the type hint. So I tried usingTypeVar("Descriptor")but this upsets MyPy. Need to understand exactly what should be done.